adding my art to the project #2939
Conversation
|
🙏 Thanks for your pull request @AutumnFawcett, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
1 similar comment
|
🙏 Thanks for your pull request @AutumnFawcett, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
There was a problem hiding this comment.
Alohaaaa @AutumnFowcett
Thanks for the contributions !
Here are some review above and bellow to fix, please address them then we will be good to go.
Folder name
- Incorrect Contribution Folder Name
- Invalid characters: Please remove any space in your folder name
- Invalid name: your folder name should follow this pattern
<github-handle>-<animation-name>
Missing meta.json values
- Please add your github handle
- Please add the name of your animation
Unaccepted change on public/cards.json
- Please remove any changes
public/cards.jsonas we do not accept any changes there
Other feedbacks within files
There are other comments/feedbacks I gave for specific lines, please address them too
| @@ -0,0 +1,27 @@ | |||
| /* styles.css */ | |||
There was a problem hiding this comment.
Incorrect CSS filename
Please correct the filename according to the given guidelines in the README.md file
| <meta charset="utf-8"> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1"> | ||
| <title> Mrs. Roboto - ROBO CSS Animation</title> | ||
| <link rel="stylesheet" type="text/css" href="style.css"> |
There was a problem hiding this comment.
Incorrect css reference
This currently refers to the correct file in your project - however
the css filename should not be style.css but styles.css
- Please adjust the name of your CSS file
- Then update this line with correct filename.
| <div class="image-container"> | ||
| <img src="1.png" alt="" class="animated-image"> | ||
| </div> |
There was a problem hiding this comment.
Unaccepted picture for the contribution
Unfortunatelly, we do not accept picture in our contributions.
Please find another way to display this picture other than uploading this in the project as a file.
|
🙏 Thanks for your pull request @AutumnFawcett, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
I understand that I am outside of the October Challenge but I am working my way through the Complete Web Developer Course and I am in the "Contributing to Opensource 2" lesson so I am just following along with the lesson to learn how to use Terminal and GitHub.☺️
Pull request checklist
meta.jsonfile.<github_username>-<art_name>without the <>.index.htmlandstyles.css.index.htmlstyles.cssmeta.jsonwith:githubHandle: being your unique github user name,artName: name of your animation